[f13-branch] Go to tty1 after "Unknown Device" dialog (#577380)

[Ales Kozumplik]

I am going to give master some nice refactoring too.
---
storage/__init__.py | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/storage/__init__.py b/storage/__init__.py
index e37f9e9..6a02c13 100644
--- a/storage/__init__.py
+++ b/storage/__init__.py
@@ -105,6 +105,11 @@ def storageInitialize(anaconda):
"could not be found. Please check your "
"parameters and try again.") % devspec,
type="custom", custom_buttons = [_("_Exit installer")])
+ # vtActivate() might fail on certain ppc64 machines
+ try:
+ isys.vtActivate(1)
+ except SystemError:
+ pass
sys.exit(1)
else:
storage.reset()

[Brian C. Lane]

Post by Ales Kozumplik
I am going to give master some nice refactoring too.
---
storage/__init__.py | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/storage/__init__.py b/storage/__init__.py
index e37f9e9..6a02c13 100644
--- a/storage/__init__.py
+++ b/storage/__init__.py
"could not be found. Please check your "
"parameters and try again.") % devspec,
type="custom", custom_buttons = [_("_Exit installer")])
+ # vtActivate() might fail on certain ppc64 machines
+ isys.vtActivate(1)
+ pass
sys.exit(1)
storage.reset()

This would be cleaner if you used the iutil.abnormal_exit(self.exitcode)
method you added in the other patch

- --
Brian C. Lane <***@redhat.com>
Red Hat / Port Orchard, WA

[Ales Kozumplik]

Post by Brian C. Lane

Post by Ales Kozumplik
+ # vtActivate() might fail on certain ppc64 machines
+ isys.vtActivate(1)
+ pass
sys.exit(1)
storage.reset()

This would be cleaner if you used the iutil.abnormal_exit(self.exitcode)
method you added in the other patch

That's right, but this is f13 so I don't want to make big changes. Or do
you mean to introduce the method and just use it this one place?

Ales

[Brian C. Lane]

Post by Ales Kozumplik

Post by Brian C. Lane

Post by Ales Kozumplik
+ # vtActivate() might fail on certain ppc64 machines
+ isys.vtActivate(1)
+ pass
sys.exit(1)
storage.reset()

This would be cleaner if you used the iutil.abnormal_exit(self.exitcode)
method you added in the other patch

That's right, but this is f13 so I don't want to make big changes. Or do
you mean to introduce the method and just use it this one place?

I'd add the new method, and then only use it in this one place for the
f13 branch. That way it is in place, and for f13 you just need to
re-factor all the vtActive calls.

- --
Brian C. Lane <***@redhat.com>
Red Hat / Port Orchard, WA

[Chris Lumens]

Post by Ales Kozumplik
diff --git a/storage/__init__.py b/storage/__init__.py
index e37f9e9..6a02c13 100644
--- a/storage/__init__.py
+++ b/storage/__init__.py
"could not be found. Please check your "
"parameters and try again.") % devspec,
type="custom", custom_buttons = [_("_Exit installer")])
+ # vtActivate() might fail on certain ppc64 machines
+ isys.vtActivate(1)
+ pass
sys.exit(1)
storage.reset()

I'm okay with this fix, but why are we running into this problem now?
Is it new or has it always been happening and we just haven't noticed?
If it's new, what's the deal?

- Chris

[Ales Kozumplik]

Post by Chris Lumens
I'm okay with this fix, but why are we running into this problem now?
Is it new or has it always been happening and we just haven't noticed?
If it's new, what's the deal?

I just tested with F12 and it happens there as well.

Ales