Discussion:
anaconda 22.20.2-1 / python-blivet 1.0.1-1 are DOA
Adam Williamson
2015-03-04 07:51:49 UTC
Permalink
Just in case folks don't see the update comment, there's two import
issues which result in the new anaconda/blivet being completely broken:

https://admin.fedoraproject.org/updates/anaconda-22.20.2-1.fc22,python-
blivet-1.0.1-1.fc22

Most notably, getPossiblePhysicalExtents() was removed from
blivet.devicelibs.lvm without anaconda being adjusted to not use it
any more.

As we need the update to fix Alpha blockers, it'd be appreciated if we
could get fixed builds ASAP, thanks :)
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net
Adam Williamson
2015-03-05 03:32:44 UTC
Permalink
Post by Adam Williamson
Just in case folks don't see the update comment, there's two import
https://admin.fedoraproject.org/updates/anaconda-22.20.2-1.fc22
,python- blivet-1.0.1-1.fc22
Most notably, getPossiblePhysicalExtents() was removed from
blivet.devicelibs.lvm without anaconda being adjusted to not use it
any more.
As we need the update to fix Alpha blockers, it'd be appreciated if
we could get fixed builds ASAP, thanks :)
So after some more work on this today, I think it turns out that we
didn't actually want to send python-blivet 1.0.1 to Alpha at all; it
was intended to land after Alpha (according to dlehman).

The good news is that, at least so far as I can see, none of the
changes in anaconda-22.20.2 - the fixes we actually want to get into
Alpha - depends on python-blivet 1.0.1. So I think for Alpha RC1 we
can simply take anaconda-22.20.2-1.fc22 and keep python-blivet-1.0-
1.fc22 (which is currently in stable). All we need to do that is an
update which only contains anaconda-22.20.2-1.fc22 (no python-blivet).

The big changes in blivet 1.0.1 can then land after Alpha and anaconda
can continue adjusting to them.

If we turn out to need further changes to anaconda and/or blivet for
Alpha, I guess we could branch from anaconda 22.20.2 / blivet 1.0 for
Alpha, and keep 22.20.3+ and 1.0.1+ as post-Alpha development branches.

Does that all sound OK to everyone? If so, it'd be great if someone
could submit the anaconda-22.20.2-1.fc22 update. Thanks!

I've added a similar note to
https://bugzilla.redhat.com/show_bug.cgi?id=1197290 , it seemed the
best place to follow up in Bugzilla.
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net
Samantha N. Bueno
2015-03-05 14:15:10 UTC
Permalink
Post by Adam Williamson
Post by Adam Williamson
Just in case folks don't see the update comment, there's two import
https://admin.fedoraproject.org/updates/anaconda-22.20.2-1.fc22
,python- blivet-1.0.1-1.fc22
Most notably, getPossiblePhysicalExtents() was removed from
blivet.devicelibs.lvm without anaconda being adjusted to not use it
any more.
As we need the update to fix Alpha blockers, it'd be appreciated if
we could get fixed builds ASAP, thanks :)
So after some more work on this today, I think it turns out that we
didn't actually want to send python-blivet 1.0.1 to Alpha at all; it
was intended to land after Alpha (according to dlehman).
The good news is that, at least so far as I can see, none of the
changes in anaconda-22.20.2 - the fixes we actually want to get into
Alpha - depends on python-blivet 1.0.1. So I think for Alpha RC1 we
can simply take anaconda-22.20.2-1.fc22 and keep python-blivet-1.0-
1.fc22 (which is currently in stable). All we need to do that is an
update which only contains anaconda-22.20.2-1.fc22 (no python-blivet).
Done, here you go:
https://admin.fedoraproject.org/updates/anaconda-22.20.2-1.fc22
Post by Adam Williamson
The big changes in blivet 1.0.1 can then land after Alpha and anaconda
can continue adjusting to them.
If we turn out to need further changes to anaconda and/or blivet for
Alpha, I guess we could branch from anaconda 22.20.2 / blivet 1.0 for
Alpha, and keep 22.20.3+ and 1.0.1+ as post-Alpha development branches.
Does that all sound OK to everyone? If so, it'd be great if someone
could submit the anaconda-22.20.2-1.fc22 update. Thanks!
Sounds like a mess, but I guess there isn't a better way.

Samantha
Post by Adam Williamson
I've added a similar note to
https://bugzilla.redhat.com/show_bug.cgi?id=1197290 , it seemed the
best place to follow up in Bugzilla.
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net
_______________________________________________
Anaconda-devel-list mailing list
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
Adam Williamson
2015-03-05 16:25:24 UTC
Permalink
Post by Adam Williamson
Post by Adam Williamson
Post by Adam Williamson
Just in case folks don't see the update comment, there's two
import issues which result in the new anaconda/blivet being
https://admin.fedoraproject.org/updates/anaconda-22.20.2-1.fc22
,python- blivet-1.0.1-1.fc22
Most notably, getPossiblePhysicalExtents() was removed from
blivet.devicelibs.lvm without anaconda being adjusted to not use
it any more.
As we need the update to fix Alpha blockers, it'd be appreciated
if we could get fixed builds ASAP, thanks :)
So after some more work on this today, I think it turns out that
we didn't actually want to send python-blivet 1.0.1 to Alpha at
all; it was intended to land after Alpha (according to dlehman).
The good news is that, at least so far as I can see, none of the
changes in anaconda-22.20.2 - the fixes we actually want to get
into Alpha - depends on python-blivet 1.0.1. So I think for Alpha
RC1 we can simply take anaconda-22.20.2-1.fc22 and keep python-
blivet-1.0- 1.fc22 (which is currently in stable). All we need to
do that is an update which only contains anaconda-22.20.2-1.fc22
(no python-blivet).
https://admin.fedoraproject.org/updates/anaconda-22.20.2-1.fc22
Post by Adam Williamson
The big changes in blivet 1.0.1 can then land after Alpha and
anaconda can continue adjusting to them.
If we turn out to need further changes to anaconda and/or blivet
for Alpha, I guess we could branch from anaconda 22.20.2 / blivet
1.0 for Alpha, and keep 22.20.3+ and 1.0.1+ as post-Alpha
development branches.
Does that all sound OK to everyone? If so, it'd be great if
someone could submit the anaconda-22.20.2-1.fc22 update. Thanks!
Sounds like a mess, but I guess there isn't a better way.
Well, AFAICS the only alternative is to find and fix all the
libblockdev bugs for Alpha, but it seemed pretty clear that dlehman
didn't intend to land it till Beta.

So obviously the lesson here is we should always update anaconda and
blivet together, except for when we shouldn't. Easy, right?! :)

Honestly I don't think it's too much of a mess, because we never
pushed a blivet build post-1.0 stable, so we don't have to do any icky
reverts or epoch bumps or anything. In the best case we won't need
further builds for Alpha at all and can just carry on from blivet
1.0.2 / anaconda 22.20.3 after Alpha is signed off, and even the
branching case isn't really horrible.
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net
Loading...